This repository has been archived by the owner on Sep 4, 2018. It is now read-only.
Remove Alcatraz from Xcode skipped plugins list on install #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumealgis
force-pushed
the
feature/whitelist-on-install
branch
2 times, most recently
from
6db011b
to
ecf1d67
Compare
Closed
guillaumealgis
force-pushed
the
feature/whitelist-on-install
branch
from
ecf1d67
to
6c2ebde
Compare
|
Rebased this PR on top of master. Could you take a look? Thanks! |
guillaumealgis
force-pushed
the
feature/whitelist-on-install
branch
from
6c2ebde
to
d5e1ddf
Compare
| XCODE_VERSION="$(xcrun xcodebuild -version | head -n1 | awk '{ print $2 }')" | ||
| PLIST_PLUGINS_KEY="DVTPlugInManagerNonApplePlugIns-Xcode-${XCODE_VERSION}" | ||
| BUNDLE_ID="com.mneorr.Alcatraz" | ||
| TMP_FILE="/tmp/${BUNDLE_ID}.xcode-defaults" |
There was a problem hiding this comment.
Probably should add $(random) somewhere in here to avoid collisions
There was a problem hiding this comment.
@kattrali not sure random is installed on OSX by default.
mktemp might work
|
LGTM, added inline comments. |
| /usr/libexec/PlistBuddy -c "delete skipped:$BUNDLE_ID" "$TMP_FILE" > /dev/null 2>&1 && { | ||
| pgrep Xcode > /dev/null && { echo 'An instance of Xcode is currently running. Please close Xcode before installing Alcatraz.'; exit 1; } | ||
| defaults write -app Xcode "$PLIST_PLUGINS_KEY" "$(< $TMP_FILE)" | ||
| echo 'Alcatraz was removed from Xcode'\''s skipped plugins list. Next time you start Xcode select "Load Bundle" when prompted.' |
There was a problem hiding this comment.
If possible, it'd be appreciated if length could be <80
guillaumealgis
force-pushed
the
feature/whitelist-on-install
branch
from
d5e1ddf
to
82871de
Compare
+ Fix coding style
guillaumealgis
force-pushed
the
feature/whitelist-on-install
branch
from
82871de
to
25c4b3d
Compare
|
I made the requested changes:
|
|
👍 Awesome! Thanks @guillaume-algis, looks good. |
kattrali
added a commit
that referenced
this pull request
Nov 27, 2015
…tall Remove Alcatraz from Xcode skipped plugins list on install
This was referenced Mar 26, 2016
This was referenced Apr 10, 2016
This was referenced Jun 5, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #281, #282, #303 and probably a whole bunch of other issues.
This is very similar #282, but just removes Alcatraz from the skipped plugins list instead of un-blocking everything.
I also took the chance to add "strict flags" to the sh script, and echoing the current selected version of Xcode after install.