This repository has been archived by the owner on Sep 4, 2018. It is now read-only.
Verify the images we download are valid before displaying them #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Simple and effective, 👍 Nice work debugging as well. |
|
👍 lgtm |
This was referenced Aug 22, 2016
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the crash "Cannot lock focus on image because it is size zero". We won't attempt to display invalid images anymore.
The origin of the invalid image data is still not 100% clear though, but I suspect that the lack of error handling in ATZDownloader (the
errorparam of the completion block is alwaysnil) might be it.I'll fix that in another PR when I have more time, and when we get to the root of the problem with @piv199 in #479.
Fixes #320 #334 #335 #479.