-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] account for changed pandas.concat sorting behavior #201
Conversation
Fix #200
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
+ Coverage 98.04% 98.20% +0.15%
==========================================
Files 24 24
Lines 1333 1340 +7
Branches 281 290 +9
==========================================
+ Hits 1307 1316 +9
Misses 5 5
+ Partials 21 19 -2
Continue to review full report at Codecov.
|
Do we know what the issue with Pandas is? Is 1.4.3 the latest version and does, say, 1.4.4 work? Basically I am wondering if this is has been wrong the whole time and is fixed now and we need to change the test or if this is a temporary issue? If it's temporary then we also need to change the pip and condas stuff so that version of pandas is never installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a known bug in pandas 1.4.3 that explains this behavior?
I'd like to understand the reason before we just ban certain versions (which would also need to be done in the installation meta data).
@orbeckst Sorry for the delay, I will investigate this issue in the weekends. |
Sure, no problem, thanks for donating your time!!!!
|
Investigating this now. Looks like in |
Behavior of this test prior to
which gives for the resulting
This means that using With
which features sorted columns. The resulting
So calling |
As for what the fix should be, I'm not exactly sure. We generally do use |
Just checked the docs, and looks like I was wrong: we're advising users there to use |
Restoring previous behavior for the |
Thank you for getting to the bottom of the problem. Does pandas-dev/pandas#47206 restore the previous behavior? If so, we can just blacklist all versions of pandas with the changed sorting behavior. That would restore our status-quo and avoid breakage of existing scripts. Should we use For the deeper question about guaranteeing sorting orders etc we should raise a separate issue. I am happy, though, that we're not giving wrong advice in our docs. |
My understanding is that this PR on
Yes, probably. I can make this change.
Would you mind opening this? I'll finish up this and #197. |
Previous `pandas` behavior prior to 1.4.3 [did not sort numeric column names](pandas-dev/pandas#47127), but this now occurs. We don't sort within other parsers, so switching this flag to be consistent with previous behavior. There is no clear reason sorting is necessary here.
@orbeckst if satisfied, please merge. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this will do it.
Fix #200 It seems that pandas 1.4.3 has some issue.