Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we have a possible undefined variable in _version? #70

Closed
DrDomenicoMarson opened this issue Sep 25, 2022 · 2 comments
Closed

Do we have a possible undefined variable in _version? #70

DrDomenicoMarson opened this issue Sep 25, 2022 · 2 comments

Comments

@DrDomenicoMarson
Copy link
Contributor

I noticed in _version.py we have at line 89 a variable dispcmd that is not defined inside of the except block, as it was defined inside the try block. Should we just move line 77 up before the try statement?
@orbeckst
Copy link
Member

Don't bother, this file is auto-generated by versioneer. I can generate a newer version and see if it goes away.

@orbeckst
Copy link
Member

Also, looking at the code, there's a high chance that dispcmd is defined before the try-block fails.

@orbeckst orbeckst mentioned this issue Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updated versioneer files alchemistry/alchemtest
2 participants
@orbeckst @DrDomenicoMarson