-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated versioneer files #73
Conversation
- only compatible with Python 3.7+ - used versioneer 0.26 - still uses vendor mode
WARNING: This PR can only be merged if we adopt NEP29 and restrict alchemtest to python ≥ 3.7. |
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
- Coverage 99.34% 99.33% -0.01%
==========================================
Files 11 11
Lines 152 151 -1
Branches 18 18
==========================================
- Hits 151 150 -1
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This PR should work after the NEP29 PR #76 is merged. |
RTD failed a Python 3.7 build with
It looks as if there's some typing in the new |
Interesting: RTD does not support Python > 3.8
|
Well, RTD does not like the new versioneer file
|
I think we should just use the old versioneer file and only update it if it fails to do what we want it to do. |
Fair enough, we’ll just leave the PR open.
… Am 10/9/22 um 11:40 schrieb Zhiyi Wu ***@***.***>:
I think we should just use the old versioneer file and only update it if it fails to do what we want it to do.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
We now use versioningit #93 |
_version
? #70