Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated versioneer files #73

Closed
wants to merge 4 commits into from
Closed

updated versioneer files #73

wants to merge 4 commits into from

Conversation

orbeckst
Copy link
Member

- only compatible with Python 3.7+
- used versioneer 0.26
- still uses vendor mode
@orbeckst
Copy link
Member Author

WARNING: This PR can only be merged if we adopt NEP29 and restrict alchemtest to python ≥ 3.7.

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #73 (0614777) into master (57458ef) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   99.34%   99.33%   -0.01%     
==========================================
  Files          11       11              
  Lines         152      151       -1     
  Branches       18       18              
==========================================
- Hits          151      150       -1     
  Misses          1        1              
Flag Coverage Δ
unittests 99.33% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/alchemtest/__init__.py 93.75% <100.00%> (-0.37%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@orbeckst
Copy link
Member Author

orbeckst commented Oct 1, 2022

This PR should work after the NEP29 PR #76 is merged.

@orbeckst
Copy link
Member Author

orbeckst commented Oct 9, 2022

RTD failed a Python 3.7 build with

Processing /home/docs/checkouts/readthedocs.org/user_builds/alchemtest/checkouts/73
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-req-build-xffisvuw/setup.py", line 12, in <module>
        import versioneer
      File "/tmp/pip-req-build-xffisvuw/versioneer.py", line 409
        LONG_VERSION_PY: Dict[str, str] = {}
                       ^
    SyntaxError: invalid syntax
    
    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-req-build-xffisvuw/
You are using pip version 10.0.1, however version 20.3.4 is available.

It looks as if there's some typing in the new versioneer.py file that's not compatible with Python 3.7. If this is the case then this PR cannot be merged until we drop 3.7.

@orbeckst
Copy link
Member Author

orbeckst commented Oct 9, 2022

Interesting: RTD does not support Python > 3.8

Error

Problem in your project's configuration. Invalid "python.version": expected one of (2, 2.7, 3, 3.5, 3.6, 3.7, 3.8, pypy3.5), got 3.9

@orbeckst
Copy link
Member Author

orbeckst commented Oct 9, 2022

Well, RTD does not like the new versioneer file

Processing /home/docs/checkouts/readthedocs.org/user_builds/alchemtest/checkouts/73
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-req-build-hsj06cht/setup.py", line 12, in <module>
        import versioneer
      File "/tmp/pip-req-build-hsj06cht/versioneer.py", line 409
        LONG_VERSION_PY: Dict[str, str] = {}
                       ^
    SyntaxError: invalid syntax
    
    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-req-build-hsj06cht/
You are using pip version 10.0.1, however version 20.3.4 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

@xiki-tempula
Copy link
Collaborator

I think we should just use the old versioneer file and only update it if it fails to do what we want it to do.

@orbeckst
Copy link
Member Author

orbeckst commented Oct 10, 2022 via email

@orbeckst
Copy link
Member Author

We now use versioningit #93

@orbeckst orbeckst closed this Mar 30, 2024
@orbeckst orbeckst deleted the update-versioneer-files branch March 30, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do we have a possible undefined variable in _version?
2 participants