Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--forwrev should be non-zero by default #18

Closed
hejamu opened this issue Nov 21, 2022 · 0 comments · Fixed by #20
Closed

--forwrev should be non-zero by default #18

hejamu opened this issue Nov 21, 2022 · 0 comments · Fixed by #20
Assignees
@hejamu

Comments

@hejamu
Copy link
Contributor

hejamu commented Nov 21, 2022

Setting forwrev to 0 results in an empty dataframe in forward_backward_convergence which breaks other stuff, making flamel unusable unless --forwrev != 0 is specified.
@hejamu hejamu mentioned this issue Nov 21, 2022
Closed
1 task
@xiki-tempula xiki-tempula mentioned this issue Dec 2, 2022
Merged
1 task
orbeckst pushed a commit that referenced this issue Dec 3, 2022
@xiki-tempula @hejamu
sane default for forwrev (#20)
119e12e 
* fix #18 
* make --forwrev=0 switch to the default None when calling ABFE (avoids a nasty crash when the 
  original default 0 is not changed)
* add test for flamel invocation with default parameters
* Update CHANGES

Co-authored-by: Henrik Jaeger <info@jaegerhenrik.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hejamu hejamu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #18 xiki-tempula/flamel
Set forwrev to 10 by default hejamu/flamel
1 participant
@hejamu