Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe zippy interfaces #1

Merged
merged 3 commits into from
Jan 2, 2013
Merged

Conversation

nlegoff
Copy link
Contributor

@nlegoff nlegoff commented Jan 2, 2013

  • Add Adapter interface
  • Add archive interface
  • Add file interface

@romainneutron
Copy link
Contributor

Can you add a copyright header for each files ?

/*
 * This file is part of Zippy.
 *
 * (c) Alchemy <info@alchemy.fr>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

Interface AdapterInterface
{
/**
* Returns adapter name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returns the adapter name


/**
* Extracts a file from the archive to the given path
* @throws RuntimeException in case the extraction failed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a blank line between description an return annotation

Add option class file header

Fix typo

Fix typo
*
* @return ArchiveInterface
*
* @throws RuntimeException in case of failure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of failure

@nlegoff
Copy link
Contributor Author

nlegoff commented Jan 2, 2013

@romainneutron This PR is Up to date

Fix CS

Fix typo

Fix CS
romainneutron added a commit that referenced this pull request Jan 2, 2013
Describe zippy interfaces
@romainneutron romainneutron merged commit 0d37e6b into alchemy-fr:master Jan 2, 2013
romainneutron pushed a commit that referenced this pull request Jan 28, 2013
fabre-thibaud pushed a commit that referenced this pull request Mar 19, 2016
@sannysoft sannysoft mentioned this pull request Oct 5, 2016
aarontong00 added a commit to aarontong00/Zippy that referenced this pull request Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants