feat(alchemy): use rundler_maxPriorityFeePerGas for fee estimate

[dancoombs]

Use the new rundler_maxPriorityFeePerGas instead of hardcoded fee modes during Alchemy provider fee estimation.

---

PR-Codex overview

Focus of the PR:

This PR focuses on refactoring and improving the gas fee handling and estimation logic in the Alchemy package.

Detailed summary:

• The GasFeeStrategy enum and GasFeeMode interface have been removed from the gas-fees.ts file.
• The GasFeeStrategy enum and GasFeeMode interface have been removed from the OnboardingController.ts file.
• The withAlchemyGasFeeEstimator function in the gas-fees.ts file has been updated to accept baseFeeBufferPercent and maxPriorityFeeBufferPercent as parameters instead of feeMode.
• The withAlchemyGasFeeEstimator function in the gas-fees.ts file now uses the alchemyClient.request method to fetch the maxPriorityFeePerGas value.
• The withAlchemyGasFeeEstimator function in the gas-fees.ts file now calculates the baseFeeIncrease and prioFeeIncrease values based on the baseFeeBufferPercent and maxPriorityFeeBufferPercent parameters.
• The withAlchemyGasManager function in the gas-manager.ts file now uses the provider.rpcClient property instead of config.provider to access the RPC client.
• The withAlchemyGasManager function in the gas-manager.ts file now accepts baseFeeBufferPercent and maxPriorityFeeBufferPercent as parameters instead of provider.
• The alchemyPaymasterAndDataMiddleware function in the gas-manager.ts file now uses the provider.rpcClient property instead of config.provider to access the RPC client.

The following files were skipped due to too many changes: packages/alchemy/src/middleware/gas-manager.ts, packages/alchemy/src/provider.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[rthomare]

I worry about this a little bit. It'd be nice to just fix the withAlchemyGasManager to not override right?

Specifically by not calling the code block below conditionally in withAlchemyGasManager if the fee ops are set in the config?

  .withFeeDataGetter(async () => ({
     maxFeePerGas: 0n,
     maxPriorityFeePerGas: 0n,
  }))

[rthomare]

curious on @moldy530's thoughts

[moldy530]

oh wait... I have a thing for this already https://github.com/alchemyplatform/aa-sdk/blob/main/packages/core/src/provider/base.ts#L311

you could potentially just override the sendUserOperation method here to do something like:

sendUserOperation = async (
    data: UserOperationCallData | BatchUserOperationCallData,
    overrides?: UserOperationOverrides
): Promise<SendUserOperationResult> => {
  super.sendUserOperation(data, overrides ?? this.overrides)
}

[dancoombs]

You can't override the fees after the paymaster has signed them

[dancoombs]

This code switches between the two middleware functions based on if the fee opts are set. If no fees are set we should use the middleware where we make gas estimation a no-op.

Not really sure I see another way to do this? The issue isn't really the fee estimation logic, its the removal of the gas estimation logic.

We could also remove the usage of alchemy_requestGasAndPaymasterAndData entirely from this code, that would keep this cleaner (but we would lose test coverage there).

[moldy530]

gotcha yea so requestGasAndPaymaster data overrides all both the fee estimates and gas estimates performed. So if you have any overrides set, then that would mean that those don't get respected if you want to use a paymaster which by default gets gas + fee estimates.

I'm good with the approach here, it makes sense.