Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cross-arch): add cross arch release pipeline #487

Merged
merged 28 commits into from
Feb 23, 2024

Conversation

0xfourzerofour
Copy link
Collaborator

Closes #421

Proposed Changes

Cargo.toml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Dockerfile.cross Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@github-actions github-actions bot added the stale label Dec 8, 2023
@github-actions github-actions bot closed this Dec 13, 2023
@0xfourzerofour 0xfourzerofour added enhancement New feature or request prevent-stale Prevent an issue from closure due to being stale and removed stale labels Dec 13, 2023
@0xfourzerofour 0xfourzerofour force-pushed the josh/release-pipeline branch 2 times, most recently from 95639a0 to 42dd119 Compare December 21, 2023 16:01
Copy link
Collaborator

@dancoombs dancoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Final couple requests here:

  1. How much of this is tested? What is the testing plan? Do we need to merge first and then iterate?

  2. Can you write 2 docs to support this code:
    a. release.md explaining the release process
    b. Update docker.md explaining the use of the 3 docker files, an overview of how to do builds, note anything that we had to do what wasn't intuitive, etc.

@0xfourzerofour
Copy link
Collaborator Author

0xfourzerofour commented Jan 31, 2024

@dancoombs The annoying thing about github is you cannot test updated workflows unless they are first in the default branch. We will need to merge first and then I will manually run each of them. I have added an override for the git tag in the workflow dispatch for patches and inital testing deploying to dockerhub

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.25%. Comparing base (0099370) to head (47e4ff6).
Report is 28 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

see 59 files with indirect coverage changes

Flag Coverage Δ
unit-tests 57.25% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 51.33% <ø> (+1.24%) ⬆️
dev 0.00% <ø> (ø)
pool 64.79% <ø> (+1.08%) ⬆️
provider 0.40% <ø> (-0.51%) ⬇️
rpc 34.72% <ø> (-2.46%) ⬇️
sim 84.46% <ø> (+0.94%) ⬆️
tasks ∅ <ø> (∅)
types 86.82% <ø> (-3.44%) ⬇️
utils 16.79% <ø> (+1.82%) ⬆️

Copy link
Collaborator

@dancoombs dancoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions, approving to unblock testing, we'll likely iterate on this a few times during testing.

Copy link
Collaborator

@dancoombs dancoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@0xfourzerofour 0xfourzerofour merged commit 899794e into main Feb 23, 2024
6 checks passed
@0xfourzerofour 0xfourzerofour deleted the josh/release-pipeline branch February 23, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prevent-stale Prevent an issue from closure due to being stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: release pipeline with cross-arch builds
2 participants