Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): return internal errors and increment metric on panic #689

Merged
merged 1 commit into from
Apr 19, 2024
Merged

feat(rpc): return internal errors and increment metric on panic #689

merged 1 commit into from
Apr 19, 2024

Conversation

dancoombs
Copy link
Collaborator

Proposed Changes

  • Previously panics would just drop the connection and silently occur
  • New behavior is to catch them, return an internal error, and increment a metric that can be alerted upon

0xfourzerofour
0xfourzerofour approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dancoombs dancoombs merged commit 09e6274 into feat/v0_7 Apr 19, 2024
7 checks passed
@dancoombs dancoombs deleted the danc/rpc-panic-metric branch April 19, 2024 01:35
@dancoombs dancoombs mentioned this pull request Apr 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xfourzerofour 0xfourzerofour 0xfourzerofour approved these changes

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dancoombs @0xfourzerofour