Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the "weight" needs to be a string problem #55

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

oshinowo-stephen
Copy link
Contributor

Describe your changes

  • ddbCharater.weight is a number and the system expects it be a string, converted on to a string if it exists otherwise it would be an empty string.

D&D Beyond character link

https://www.dndbeyond.com/characters/99603501
https://www.dndbeyond.com/characters/98857388
https://www.dndbeyond.com/characters/7988555/5uCKLU

Pre-review checklist

  • I have added a description of my changes
  • I have formatted my code with yarn format
  • I have added a link to a D&D Beyond character that can be used to test these changes
  • I have read the contributing guidelines
  • I agree to the code of conduct

@voidrender
Copy link
Member

Thank you! This seems solid! I'll test test this by pulling it into Alchemy here in the next few hours.

Copy link
Member

@voidrender voidrender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed fix! Thank you again!

@voidrender voidrender merged commit 4971a8e into alchemyrpg:main Oct 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants