Trackers #57
Trackers #57
Conversation
src/convert.ts
Outdated
| name: 'XP', | ||
| category: 'experience', | ||
| color: 'Yellow', | ||
| max: 355000, |
There was a problem hiding this comment.
doesn't necessarily need to hold up this PR, but I imagine the most common way people use the XP tracker is to track XP until their next level (rather than theoretical max XP at lv20, or something). seems like all we'd need to do to support that is to have a static map between levels and XP counts, and then use the character's level to put the correct total here.
There was a problem hiding this comment.
Good point! And yeah, we actually do this for characters created in Alchemy, too. I could yoink that function from our code.
There was a problem hiding this comment.
Alright, I went head and pulled in those functions from the Alchemy 5e implementation and updated the way the XP tracker is created so that it tracks XP until next level now.
Instead of 0 / 355000, set the XP tracker's current `value` to the amount of experience earned within the current level and the `max` to the experience required to reach the next level.
|
Whoops, I just spotted an error, fixing... |
Instead of adjusting the value relative to the current level (which would look nice on the bar), this instead shows the current total experience as the value, and the next level as the max. This is closer to what D&D Beyond shows, although it has a nicer bar that shows the progress to the next level. We don't really have a way to do that solely with a tracker at the moment, though.
|
Okay, now it's working correctly and in a way that mirrors what you see in D&D Beyond pretty closely. The only thing that's a little weird is that the tracker bar doesn't show relative % towards the next level, but I don't think there's much we can do about that right now without adjusting the value/max for the relative distance to the next level, which would look a bit odd numerically. 2023-11-26.at.20.51.20.-.Gold.Otter.mp4 |
|
Alchemy is on this version now, as of about 2 minutes ago. 🚀 |
Describe your changes
A few months ago, I implemented HP and XP trackers on the Alchemy side of the import process, but in fixing a bug this week related to importing from JSON, I realized that it would be advantageous for this conversion to happen within ddb2alchemy instead. There are a few benefits:
Demo
I pointed my local build of the Alchemy app to this branch to test the import process with the below D&D Beyond character link.
2023-11-23.at.21.29.53.-.White.Stork.mp4
D&D Beyond character link
https://www.dndbeyond.com/characters/22233192/BKPCYDPre-review checklist
yarn format