Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add javascript: prefix to compiled bookmarklet #59

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Add javascript: prefix to compiled bookmarklet #59

merged 1 commit into from
Nov 29, 2023

Conversation

thatbudakguy
Copy link
Collaborator

This is required for Chrome to allow you to create a bookmark, otherwise it'll complain it's an invalid URL.

@thatbudakguy thatbudakguy changed the title Add js: prefix to compiled bookmarklet Add javascript: prefix to compiled bookmarklet Nov 29, 2023
@thatbudakguy
Add javascript: prefix to compiled bookmarklet
c6244d6 
This is required for Chrome to allow you to create a bookmark, otherwise it'll complain it's an invalid URL.
@voidrender
Copy link
Member

voidrender commented Nov 29, 2023 •
edited
Loading

Is this going to be overwritten by the build script? If so, there's likely a way we can fit this into the build process to ensure that doesn't happen.

Nevermind, that only outputs the index.

voidrender
voidrender approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@voidrender voidrender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@thatbudakguy thatbudakguy merged commit 2120f7c into main Nov 29, 2023
2 checks passed
@thatbudakguy thatbudakguy deleted the bookmarklet-fmt branch November 29, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voidrender voidrender voidrender approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thatbudakguy @voidrender