Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update processing of config #41

Merged
merged 1 commit into from
May 24, 2021
Merged

Conversation

Roman-Mitusov
Copy link
Contributor

@Roman-Mitusov Roman-Mitusov commented May 24, 2021

Update processing of config in config.go file to be able to have different paths in main browser layout and specific browser version spec.
Mainly it is useful while testing both on chrome desktop and mobile at the same time.
Example config for this case is

chrome:
  defaultVersion: "84.0"
  path: "/"
  meta:
    annotations:
      k8s.v1.cni.cncf.io/networks: bridge-conf-1
  kernelCaps:
  - SYS_ADMIN
  volumes:
    - name: kvm
      hostPath:
       path: /dev/kvm       
  versions:
    '84.0':
      image: selenoid/vnc:chrome_84.0
      spec:
       resources:
         requests:
           memory: 500Mi
           cpu: '0.5'
         limits:
           memory: 1.5Gi
           cpu: '1'
    '90.0':
      image: selenoid/vnc:chrome_90.0
      spec:
       resources:
         requests:
           memory: 500Mi
           cpu: '0.5'
         limits:
           memory: 1.5Gi
           cpu: '1'
    'mobile-86.0':
      image: selenoid/chrome-mobile:86.0
      path: "/wd/hub"
      privileged: true
      spec:
      volumeMounts:
        - name: kvm
          mountPath: /dev/kvm
       resources:
         requests:
           memory: 500Mi
           cpu: '0.5'
         limits:
           memory: 3.5Gi
           cpu: '2'         

In this case both mobile and desktop should be in the same browser layout but paths should be different, because mobile chrome is using appium (it exposes "/wd/hub" path) and desktop chrome is using default path "/", because we directly connect to chromedriver executable.

…in browser layout and specific browser version spec
@alcounit alcounit merged commit 43ab7a0 into alcounit:main May 24, 2021
@alcounit
Copy link
Owner

Thanks @Roman-Mitusov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants