This repository has been archived by the owner on Jan 6, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #16. I also allowed for decimal rest lengths since they are parsed similarly to note lengths.
Thank you for providing some low-hanging fruit for those of us just starting out.
To follow up, should expressing length in seconds also be allowed in decimals (e.g. 2.5s)? I think millisecond values have to be integers, though.
As for the set-note-length function discussed in the issue, I noticed that in the documentation you suggest just calling the note-length function inside set-duration. Would you still like to add set-note-length as a convenience function of sorts?