-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify inline Clojure code #109
Conversation
After all my hard work simplifying things 😉 |
Sorry @crisptrutski! :) |
Quoth @crisptrutski in #89:
We should probably fix this before merging this PR -- seems like it could lead to unexpected behavior :/ |
aecbf8b
to
ab66b7f
Compare
ab66b7f
to
40e318a
Compare
Hmm... this is a tricky problem. The Clojure reader must be able to differentiate somehow between symbols in bindings (and their subsequent references) and symbols elsewhere, so that it doesn't try to resolve them, but I haven't figured out how. |
40e318a
to
79e8415
Compare
@crisptrutski Check this out -- I talked to @micha, and it turns out that all we really need to do to get this working is to refer I've added This will get trickier in 1.0.0 when we're packaging Alda as an uberjar, and thus won't have access to |
Looks great, this is exactly what I was thinking also 👍 |
Simplify inline Clojure code
Brandon Bloom (creator of backtick) had this to say:
That last idea -- wrapping the expressions in an anonymous function and using |
Reminds me a bit of JavaScript 😉 |
Closes #108