Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: disableEditor and more callbacks #342

Merged
merged 1 commit into from
Apr 9, 2024
Merged

feat: disableEditor and more callbacks #342

merged 1 commit into from
Apr 9, 2024

Conversation

slash-84
Copy link
Contributor

@slash-84 slash-84 commented Apr 8, 2024 •
edited

  • Adds the possibility to disable event editor globally.
  • Adds new callbacks: onEventEdit, onCellClick

Use scenario: I want to detect when a user click on a cell without opening the event creation modal.

@slash-84 slash-84 changed the title feat: disableEditor and firing more events feat: disableEditor and more callbacks Apr 8, 2024
@aldabil21 aldabil21 merged commit 69050cc into aldabil21:master Apr 9, 2024
2 checks passed
@aldabil21
Copy link
Owner

aldabil21 commented Apr 9, 2024 •
edited

I've checked this

  1. We can remove disableEditor since editable does the job
  2. Event item cannot be focusable which disableViewer=true

Will adjust and push

@aldabil21 aldabil21 mentioned this pull request Apr 9, 2024
Merged
@slash-84 slash-84 deleted the feat/events branch April 9, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slash-84 @aldabil21