Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lemire
The speedups are not related to this change, without them there's around [+2%; +3%] slowdown, but they seem to compensate for the extra added logic. I'm particularly happy that mesh.txt benchmarks (that are super sensitive to instruction count) are not hurt in the end.
We also seem to have made it past lexical in the big_ints case which is nice.
Benchmarks:
big_ints
uniform
canada.txt
mesh.txt