Issue #61 fixes - stream could read incomplete data and returns too early resulting incomplete packet #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceived from stream. Fixes #61
* refactor tests expection handling
aldas
changed the title
create codecov configuration so very small coverage changes will not be marked as failures
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
============================================
- Coverage 99.08% 99.04% -0.05%
- Complexity 752 764 +12
============================================
Files 63 64 +1
Lines 1743 1771 +28
============================================
+ Hits 1727 1754 +27
- Misses 16 17 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic that BinaryStreamConnection is using has problem (see #61) when stream reads incomplete packet and returns too early resulting incomplete packet.
Although modbus packet response is really small there seems to be PLCs/networks that fragment response packet to multiple TCP packet fragments. As we use PHP
stream_selectnon-blocking way we could return with data before all bytes arrive to stream.to overcome this StreamHandler now could use callback to check if data read from stream is enough