Skip to content

Commit

Permalink
Fix WebDownloadPrivate::didFinishLoading signature
Browse files Browse the repository at this point in the history
Signature of ResourceHandleClient::didFinishLoading changed recently and is not
a pure virtual, thus it wasn't called nor the compiler complained of
it missing.

Fixes last part of https://dev.haiku-os.org/ticket/8737 (downloads state unfinished)
  • Loading branch information
aldeck committed Jul 20, 2012
1 parent 5a75e8b commit 16691d8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Source/WebKit/haiku/API/WebDownloadPrivate.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ void WebDownloadPrivate::didReceiveData(ResourceHandle*, const char* data, int l
m_progressListener.SendMessage(&message);
}

void WebDownloadPrivate::didFinishLoading(ResourceHandle* handle)
void WebDownloadPrivate::didFinishLoading(ResourceHandle* handle, double /*finishTime*/)
{
handleFinished(handle, B_DOWNLOAD_FINISHED);
}
Expand Down
2 changes: 1 addition & 1 deletion Source/WebKit/haiku/API/WebDownloadPrivate.h
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class WebDownloadPrivate : public WebCore::ResourceHandleClient {
// ResourceHandleClient implementation
virtual void didReceiveResponse(ResourceHandle*, const ResourceResponse&);
virtual void didReceiveData(ResourceHandle*, const char*, int, int);
virtual void didFinishLoading(ResourceHandle*);
virtual void didFinishLoading(ResourceHandle*, double);
virtual void didFail(ResourceHandle*, const ResourceError&);
virtual void wasBlocked(ResourceHandle*);
virtual void cannotShowURL(ResourceHandle*);
Expand Down

0 comments on commit 16691d8

Please sign in to comment.