Add URL to history #39
Comments
|
While testing a fix to this I ran across a pernicious IE bug. IE does not correctly close the socket when the window is refreshed or left via the back button. As a result, we need to manually close the socket. Worse, when the user navigates back to the same page via the forward button, IE magically resurrects the closed socket. Both the above IE bugs will be handled as part of this job as they relate to window.location. |
- Add url to history on document creation. - Fix IE bus: 1. IE does not correctly close the socket when the window is refreshed or left via the back button. As a result, we need to manually close the socket. socket.close() does not appear to work, so we send down our own "close" event instead that we handle server-side. 2. When the user navigates back to the same page via the forward button, IE magically resurrects the closed socket.
See the extensive comment in init-app.js about this nasty Chrome bug. This was causing codr.io to refresh at a frenetic pace whenever you accessed it from Chrome. The change to index.html is an unrelated removal of illegal </input> tags.
|
Yuck. Re-opening again. We need to make it so that the title shows up correctly in history. Right now they all show up as "Untitled" for new documents and "Loading . . ." for old ones. To consider: use history.js |
After a losing a great deal time fighting numerous incompatibilities, I finally settled on this approach that appears to make history reasonable across browsers. In IE, there's not much we can do. It always says 'codr.io' and new documents get no history entry. In FF and GC things work better. To work around a FF issue we don't load the new title until we get the new URL. I think there are better ways to work around this, but it's not worth more time at this point.
Avoids delay before setting the title on a new document creation.
Right now the back button doesn't work if you leave a codr.io document.
The text was updated successfully, but these errors were encountered: