Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 24 use jar files #66

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DarkStar1
Copy link
Collaborator

CHECKLIST

We will not consider a PR until the following items are checked off--thank you!

  • There aren't existing pull requests attempting to address the issue mentioned here
  • Submission developed in a feature branch--not master

CONVINCING DESCRIPTION

... Describe the changes provided by this PR...

This PR addresses issue 24 by changing the deployment from building and deploying the amp files to just deploying the jar files as requested.

RELATED INFORMATION

... If you have any supporting material such as issues that are addressed by this
PR, links outlining any special techniques or libraries used, etc that will help
us to evaluate this PR. Please include that information here...

Fixes #

BE WARNED

  • If any of the checklist items are missed, incomplete or invalid we will not accept the PR
  • If you are not responsive to feedback on your PR we will not accept the PR
  • If we do not accept your PR we will provide feedback on the PR indicating why
  • After some time, we will close PRs that have not been accepted

When we decline or close your PR. You are encouraged to address the concerns outlined in the
PR and then re-submit it. We want contributions. We also need for them to be of high quality
and high value and to not take undue resources away from the features and enhancements the
core team is working on. Thanks for understanding!

@AFaust
Copy link
Collaborator

AFaust commented Aug 10, 2021

@DarkStar1 you need to be careful and pick the "right" JARs to install. If you simply replace the AMPs with the JARs, you are missing out on the accompanying configuration. There is a special "installable" JAR artifact which includes the Java classes AND the configuration of the module, which you want to pick. Also note that if you are replacing the AMPs with the JARs, you need to manually handle all the dependency JARs of Ignite and co...

@DarkStar1
Copy link
Collaborator Author

I was not aware of this thanks. I'll rectify this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants