-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for deprecated python and django versions #100
Conversation
195e73f
to
2c701ac
Compare
My preference is to not bother with tox for GitHub Actions. I'd rather just use each testing tool independently. I'd like to wait a few more weeks before we merge this until Python 3.5 is also end-of-life and we can remove it from the build matrix. How does that sound to you? https://endoflife.date/python |
I think Python 3.5 should not be dropped before we no longer support django 2.2. |
While I recognize that django 2.2 is still supported, and django 2.2 promises to not break with python 3.5 because it is LTS, I do not think we should do the same. I do not wish to have LTS releases of Aldjemy. Those wishing to remain on an unsupported version of Python are free to also remain on an unsupported version of this library. |
The advantage of using tox during CI, is that we test tox.ini at the same time. It is maintained and updated.
Fine by me. |
9a0b2cc
to
37027e9
Compare
I'm inclined to get a new release out so that we can merge this pull request, including the dropping of Python 3.5 a bit early. Is there any work that we really want to get in the 0.11 release? The next release after it will be 1.0. |
From my point of view, master can be released as 0.11. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a couple things that need to be cleaned up from this PR, but I'm going to do that in a followup PR.
fixes #99