Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for deprecated python and django versions #100

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

ticosax
Copy link
Contributor

@ticosax ticosax commented Aug 24, 2020

fixes #99

@ticosax ticosax force-pushed the remove-depreated-versions branch 4 times, most recently from 195e73f to 2c701ac Compare August 24, 2020 07:36
@ryanhiebert
Copy link
Member

My preference is to not bother with tox for GitHub Actions. I'd rather just use each testing tool independently.

I'd like to wait a few more weeks before we merge this until Python 3.5 is also end-of-life and we can remove it from the build matrix. How does that sound to you? https://endoflife.date/python

@Mogost
Copy link
Member

Mogost commented Aug 24, 2020

I think Python 3.5 should not be dropped before we no longer support django 2.2.
In our case, it is correct to build on the versions that django supports.

@ryanhiebert
Copy link
Member

While I recognize that django 2.2 is still supported, and django 2.2 promises to not break with python 3.5 because it is LTS, I do not think we should do the same. I do not wish to have LTS releases of Aldjemy.

Those wishing to remain on an unsupported version of Python are free to also remain on an unsupported version of this library.

@ticosax
Copy link
Contributor Author

ticosax commented Aug 25, 2020

My preference is to not bother with tox for GitHub Actions. I'd rather just use each testing tool independently.

The advantage of using tox during CI, is that we test tox.ini at the same time. It is maintained and updated.

I'd like to wait a few more weeks before we merge this until Python 3.5 is also end-of-life and we can remove it from the build matrix. How does that sound to you? https://endoflife.date/python

Fine by me.

@ryanhiebert
Copy link
Member

I'm inclined to get a new release out so that we can merge this pull request, including the dropping of Python 3.5 a bit early. Is there any work that we really want to get in the 0.11 release? The next release after it will be 1.0.

@ticosax
Copy link
Contributor Author

ticosax commented Aug 28, 2020

From my point of view, master can be released as 0.11.
Thanks for coordinating it

@stale
Copy link

stale bot commented Oct 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 27, 2020
@ryanhiebert ryanhiebert marked this pull request as ready for review November 5, 2020 17:34
Copy link
Member

@ryanhiebert ryanhiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a couple things that need to be cleaned up from this PR, but I'm going to do that in a followup PR.

@ryanhiebert ryanhiebert merged commit 44438e0 into aldjemy:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are you fine with droping support for python2.7 ?
3 participants