Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong units in free space bars of File Browser #507

Closed
J0hnTR opened this issue Apr 4, 2021 · 2 comments
Closed

Wrong units in free space bars of File Browser #507

J0hnTR opened this issue Apr 4, 2021 · 2 comments

Comments

@J0hnTR
Copy link

J0hnTR commented Apr 4, 2021

Greetings!

Just a quick note - there are wrong units in free space bars of File Browser.

There are Mb where Gb should really be, at least in Russian language:
Rus
Also popup message is a mess of Russian and English units (see "Gb", but "Мб", strange).

As for Russian language, according to the English: "Gb" is "Гб", "Mb" is "Мб", "Kb" is "Кб", "b" is "б".
Russian lang file is OK - there are "Гб", not "Мб", in it (checked).

If English translation is set - everything is fine:
Eng

Thinking a little - may it be something about THIS?
if(devSize >= _1GB_) { replace_char(fsize, 'M', 'G'); }
Buuuuuuut English "M" differs from Russian one, can it be the cause of all troubles?..)

Maybe (just maybe, I'm almost not a programmer!) not the chars should be replaced?
But STR_MEGABYTE with STR_GIGABYTE, of already localized text?

Thank you!

aldostools added a commit that referenced this issue Apr 6, 2021
- Added "GB Free" in 23 languages
- Addressed issue #507
- Now report GB Free instead of MB when size is over 1024 MB
@aldostools
Copy link
Owner

Check if it's fixed in the latest build... update using the built-in updater or download the PKG from the release page

@J0hnTR
Copy link
Author

J0hnTR commented Apr 7, 2021

Check if it's fixed in the latest build... update using the built-in updater or download the PKG from the release page

Everything is fine now, thank you!

@J0hnTR J0hnTR closed this as completed Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants