This repository has been archived by the owner on Feb 1, 2019. It is now read-only.
Fix issues with plugin app_config field. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberstar
force-pushed
the
issue/fix-plugin-forms-with-respect-to-apphooks
branch
from
bba4f9e
to
be765fc
Compare
|
rebased. |
| @@ -1,5 +1,10 @@ | |||
| {% load i18n apphooks_config_tags %} | |||
| <div class="aldryn aldryn-jobs aldryn-jobs-categories"> | |||
| {% if plugin_configuration_error %} | |||
There was a problem hiding this comment.
@cyberstar be aware that this changed in: #61
cyberstar
force-pushed
the
issue/fix-plugin-forms-with-respect-to-apphooks
branch
from
18a5d63
to
30da040
Compare
|
rebased. |
| @@ -2,6 +2,11 @@ | |||
|
|
|||
| <div class="aldryn aldryn-jobs aldryn-jobs-categories"> | |||
| <div class="list-group"> | |||
| {% if plugin_configuration_error %} | |||
There was a problem hiding this comment.
this needs to be outside of the list group
|
LGTM |
1 similar comment
|
LGTM |
Perform app_config filtering; display app configs that exist but either not app hooked or page is not published; prevent 500 if apphook was deleted (for plugins); change help text for app_config field (no migration).
Basicly most test cases could be adapted form NewsletterRegistration test cases.
…lict after rebase.
cyberstar
force-pushed
the
issue/fix-plugin-forms-with-respect-to-apphooks
branch
from
d20a415
to
d919a8e
Compare
|
rebased |
|
FE LGTM |
cyberstar
pushed a commit
that referenced
this pull request
Jul 13, 2015
…t-to-apphooks Fix issues with plugin app_config field.
cyberstar
pushed a commit
that referenced
this pull request
Jul 13, 2015
Also small fix for version controlled content for jobs content. Relyes on PR #54 (which introduces namespace_is_apphooked)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces:
Should fix #66