Slight adjustments on view mixins.

divio · Dec 25, 2015 · bca1ad8 · bca1ad8
1 parent 4188216
commit bca1ad8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/aldryn_newsblog/views.py b/aldryn_newsblog/views.py
@@ -92,13 +92,16 @@ def dispatch(self, request, *args, **kwargs):
 
     def get_queryset(self):
         # filter available objects to contain only resolvable for current
-        # language
+        # language. IMPORTANT: after .translated - we cannot use .filter
+        # on translated fields (parler/django limitation).
+        # if your mixin contains filtering after super call - please place it
+        # after this mixin.
         qs = super(AppHookCheckMixin, self).get_queryset()
         return qs.translated(*self.valid_languages)
 
 
-class ArticleDetail(PreviewModeMixin, TranslatableSlugMixin, AppConfigMixin,
-                    AppHookCheckMixin, TemplatePrefixMixin, DetailView):
+class ArticleDetail(AppConfigMixin, AppHookCheckMixin, PreviewModeMixin,
+                    TranslatableSlugMixin, TemplatePrefixMixin, DetailView):
     model = Article
     slug_field = 'slug'
     year_url_kwarg = 'year'
@@ -190,9 +193,8 @@ def get_next_object(self, queryset=None, object=None):
             return None
 
 
-class ArticleListBase(
-        TemplatePrefixMixin, PreviewModeMixin,
-        ViewUrlMixin, AppConfigMixin, AppHookCheckMixin, ListView):
+class ArticleListBase(AppConfigMixin, AppHookCheckMixin, TemplatePrefixMixin,
+                      PreviewModeMixin, ViewUrlMixin, ListView):
     model = Article
     show_header = False
 

diff --git a/test b/test
@@ -1,3 +1,3 @@
 #!/bin/bash
 
-djangocms-helper aldryn_newsblog --cms test --extra-settings=test_settings $@
+djangocms-helper aldryn_newsblog --cms test --boilerplate --extra-settings=test_settings $@