Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jscoverage better way #12

Closed
fengmk2 opened this issue Jun 30, 2012 · 6 comments
Closed

jscoverage better way #12

fengmk2 opened this issue Jun 30, 2012 · 6 comments
Assignees
@fengmk2
Labels
enhancement
Milestone
node-cluster2.0

Comments

@fengmk2
Copy link
Collaborator

fengmk2 commented Jun 30, 2012

Working on it.
@ghost ghost assigned fengmk2 Jun 30, 2012
@aleafs
Copy link
Owner

aleafs commented Jun 30, 2012

这个代码的单元测试比较难做，要测进程的启动、停止。求方法 @q3boy

@fengmk2
Copy link
Collaborator Author

fengmk2 commented Jun 30, 2012

还好吧。

@aleafs
Copy link
Owner

aleafs commented Jun 30, 2012

你看我覆盖率很低的，求指点，但是不要暴露private变量

@fengmk2
Copy link
Collaborator Author

fengmk2 commented Jun 30, 2012

没问题，搞掂@ 你

fengmk2 added a commit that referenced this issue Jun 30, 2012
@fengmk2
#12 use NODE_CLUSTER_COV detect jscoverage test. Add jsdoc for index.js;
22888ba
@q3boy
Copy link

q3boy commented Jun 30, 2012

什么东东?测进程启动停止的话..我原来nae里面弄过.感觉也不是太麻烦啊.

On Sat, Jun 30, 2012 at 9:26 PM, aleafs <
reply@reply.github.com

wrote:

这个代码的单元测试比较难做，要测进程的启动、停止。求方法 @q3boy

Reply to this email directly or view it on GitHub:
https://github.com/aleafs/node-cluster/issues/12#issuecomment-6685235

fengmk2 added a commit that referenced this issue Jun 30, 2012
@fengmk2
#12 add test case for lib/worker.js: 90% for this file.
8047515
@fengmk2
Copy link
Collaborator Author

fengmk2 commented Jun 30, 2012

@aleafs 不容易啊，lib/worker.js 覆盖到90%了。

fengmk2 added a commit that referenced this issue Jul 1, 2012
@fengmk2
#12 add lib/common.js unittest
e38bb1c
@fengmk2 fengmk2 closed this as completed in d30ad4e Jul 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengmk2 fengmk2

Labels
enhancement
Projects
None yet
Milestone
node-cluster2.0
Development

No branches or pull requests
3 participants
@q3boy @fengmk2 @aleafs