New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to explicitily ask for async.callback deletion. #3

Closed

ShogunPanda wants to merge 1 commit into alebsack:master from ShogunPanda:master

ShogunPanda commented Dec 4, 2013

See also: #2

In mperham#24 you changed the async.callback to async.orig_callback.

As you can see here https://github.com/faye/faye-websocket-ruby/blob/master/lib/faye/websocket.rb#L72, that made this gem not working.
Why did you make that change?

In my fork I put it under a configuration variable so is not universal by default.

Hope this helps.
Thanks and regards.
Shogun


          Added option to explicitily ask for async.callback deletion.

54e55b5

coveralls commented Dec 4, 2013

Coverage remained the same when pulling 54e55b5 on cowtech-open:master into e04e28c on alebsack:master.

ShogunPanda closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment