Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confusion on focal length and eye position #2

Closed
nafis95 opened this issue Sep 21, 2018 · 1 comment
Closed

confusion on focal length and eye position #2

nafis95 opened this issue Sep 21, 2018 · 1 comment

Comments

@nafis95
Copy link

nafis95 commented Sep 21, 2018

When i was writing code for viewing_ray, i noticed that in the .json files, the eye and the focal length have different values. Example, for the sphere_and_plane.json file,

"focal_length": 3,
"eye": [0,0,5],

So I am bit confused here as based on lecture, I though the eye would be positioned at the focal point.

Another point, in the readme, its mentioned -

The image rectangle (e.g., 640 pixels by 360 pixels) is placed so the image center is directly in front of the "eye" point at a certain "focal length" $d$.

However, in some of the .json files, i dont think it follows this assumption. For example, in the sphere-packing.json file,

"eye": [9.6,0.3,10],

So is the eye positioned such that it is looking at the image screen at an angle? Or is the image plane also rotated to match the eye?

@velociraptor111
Copy link

The way I see it is that, when the eye is at location "eye": [0,0,5]" and the "focal_length": 3
this means that the image plane is at position [0,0,2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants