Makeassert.Zero harder to misuse

[twpayne]

Firstly, thank you for this excellent library! I'm slowly migrating my projects from stretchr/testify to alecthomas/assert.

What's wrong with this code?

    assert.Zero(t, 0, len(foo), "foo should have length zero")

Spoiler alert: this test always passes, no matter how big len(foo) is.

Is there a way to make this API harder to misuse?

[glesica]

Aren't you calling it wrong, though? There's no expected value for that function, it's assumed to be whatever the zero value is for the type. Or do you mean that it's easy to accidentally call incorrectly and then end up with a test that always passes?

[glesica]

Oh, I guess this also ought to fix your case... 929325d

[twpayne]

Or do you mean that it's easy to accidentally call incorrectly and then end up with a test that always passes?

Exactly. Your fix looks great, thank you!

[twpayne]

Closing due to inactivity.