Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust lexer #548

Merged
merged 2 commits into from Sep 18, 2021

Conversation

siddhant-deepsource
Copy link
Contributor

@siddhant-deepsource siddhant-deepsource commented Sep 16, 2021

Hey, 馃憢

In one of the rust files from hexyl/hexyl.rs : src/bin/hexyl.rs , chroma was failing to highlight the lines especially the function around these lines. Here's a screenshot of how these looked like when highlighted by chroma :

Screenshot 2021-09-17 at 2 20 40 AM

After checking the same snippet on pygments (screenshot attached below), it was found that maybe we need to update the rust lexer in chroma w.r.t pygments.

Screenshot 2021-09-17 at 2 22 36 AM

Therefore, I have updated the rust lexer using the pygments2chroma.py script (really handy script btw 馃挴 ). Please take a look and suggest any changes that may be necessary.

Thanks for this amazing project and the work put into it. 馃檶

@siddhant-deepsource
Copy link
Contributor Author

@alecthomas Have fixed the failing tests, can you please take another look? Thanks.

@alecthomas
Copy link
Owner

Thanks for contributing!

@alecthomas alecthomas merged commit 04ed07d into alecthomas:master Sep 18, 2021
@siddhant-deepsource siddhant-deepsource deleted the update-rust-lexer branch September 18, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants