Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlights numbers in java #703

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Conversation

serhack
Copy link
Contributor

@serhack serhack commented Nov 10, 2022

No description provided.

@alecthomas
Copy link
Owner

alecthomas commented Nov 10, 2022

Thanks for the PR! There are tests for the lexer if you'd like to extend them, to verify everything is working. You can run them with:

./bin/go test ./lexers/...

To update the test, edit ./lexers/tesdata/java.actual to add the appropriate syntax, and run the above again. It should fail because the expected state is now different.

If the actual result looks correct run the following to finalise it:

RECORD=true ./bin/go test ./lexers

@serhack
Copy link
Contributor Author

serhack commented Nov 10, 2022

Thanks, those comments are pure gold for me! :) Honestly I feel like a little bit of challenge understanding how to contribute to Chroma but it's nice to have such welcoming messages!

@alecthomas alecthomas merged commit a242abf into alecthomas:master Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants