Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer Reuse Inconsistency #106

Closed
pascaldekloe opened this issue Aug 12, 2022 · 1 comment
Closed

Buffer Reuse Inconsistency #106

pascaldekloe opened this issue Aug 12, 2022 · 1 comment

Comments

@pascaldekloe
Copy link
Contributor

Some marshalers reuse the buffer. For example, Gotiny applies an encoder which always returns the same buffer. For a better comparison it should allocate the bytes like the others do.

An other option is to allow each codec to use the fastest option available, including buffer reuse. Or, we could measure both with a clear distinction for the reuse case, like b.Run("reuse", ….

The issue was noted by @inkeliz with his Karmen format.
@alecthomas
Copy link
Owner

Pull requests are welcomed!

pascaldekloe added a commit to pascaldekloe/go_serialization_benchmarks that referenced this issue Aug 12, 2022
@pascaldekloe
Have all marshal method allocate the data. Memory reuse [encoders, ar…
0e17365 
…enas, etc.] could be added with a clear distinction, like b.Run("reuse", …).

Fixes issue alecthomas#106 and alecthomas#36.
@pascaldekloe pascaldekloe mentioned this issue Aug 12, 2022
Merged
@ymz-ncnk ymz-ncnk mentioned this issue Jan 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alecthomas @pascaldekloe