This repository has been archived by the owner on Apr 10, 2019. It is now read-only.
Use maligned instead of aligncheck #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
richvdh
added a commit
to matrix-org/gomatrixserverlib
that referenced
this pull request
Nov 9, 2017
gometalinter now uses `maligned` instead of `aligncheck` (alecthomas/gometalinter#367), so we need to update our config accordingly.
richvdh
added a commit
to matrix-org/dendrite
that referenced
this pull request
Nov 13, 2017
gometalinter now uses `maligned` instead of `aligncheck` (alecthomas/gometalinter#367), so we need to update our config accordingly.
richvdh
added a commit
to matrix-org/dendrite
that referenced
this pull request
Nov 14, 2017
gometalinter now uses `maligned` instead of `aligncheck` (alecthomas/gometalinter#367), so we need to update our config accordingly.
richvdh
added a commit
to matrix-org/dendrite
that referenced
this pull request
Nov 14, 2017
gometalinter now uses `maligned` instead of `aligncheck` (alecthomas/gometalinter#367), so we need to update our config accordingly.
erikjohnston
pushed a commit
to matrix-org/dendrite
that referenced
this pull request
Nov 15, 2017
* Update gometalinter config gometalinter now uses `maligned` instead of `aligncheck` (alecthomas/gometalinter#367), so we need to update our config accordingly. * Update gometalinter * Disable gotype linter gotype does not seem to play nicely with the gb vendor directory. In particular, it wants each of our dependencies to be built and installed (see golang/go#10969), but (empirically) it will not accept them being installed in `pkg` but insists on them being in `vendor/pkg`. This presents a problem because `gb build` builds the packages into `pkg` (which doesn't seem entirely unreasonable since `.` comes before `vendor` in `$GOPATH`). `go install github.com/x/y` does install in `vendor/pkg` but requires us to know the name of each package. The general conclusion of alecthomas/gometalinter#91 seems to have been that the easiest thing to do is to disable `gotype` for now. * Fix `unparam` lint * Fix goshadow lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92