This repository has been archived by the owner on Jun 14, 2022. It is now read-only.
Add enum support via interface #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a type implements JSONSchemaEnums() it will be assumed to be a enum and be called to get enum values.
|
@alecthomas hi, any opinion about this? |
alecthomas
reviewed
Aug 3, 2018
| @@ -68,6 +80,11 @@ type TestUser struct { | |||
| Feeling ProtoEnum `json:"feeling,omitempty"` | |||
| Age int `json:"age" jsonschema:"minimum=18,maximum=120,exclusiveMaximum=true,exclusiveMinimum=true"` | |||
| Email string `json:"email" jsonschema:"format=email"` | |||
|
|
|||
| TestEnumVal ABCEnumVal `json:"test_enum_val,omitempty"` | |||
There was a problem hiding this comment.
I don't mind this approach, but I'm still not sure why not just support a jsonschema:"enum=a,b,c" tag parameter?
There was a problem hiding this comment.
In my case code duplication. I already have lists of enums to handle JSON marshall/unmarshalling for various types so a approach like the removes the need to keep the struct tags in sync.
|
Any movement on this PR? Would really like to avoid using a fork ;) Given this is a pretty minimal library I would prefer the tag parameter option. |
|
@wolfeidau Hi, im not actively working on this. Maybe doing it using tag parameter option should be separate PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, would this a valid way of adding more flexible enum support? my use case is various enum types that already have string<->int translation maps so
JSONSchemaEnums()would just be a range loop to collect strings and return them.Some questions and concerns:
Weird or confusing to create a values from the type and call code when "reflecting"? maybe only support value receiver method?
Support more then one level of pointers?
Support enum type? spec seem to say the type is optional for enum.
TODO:
Document
Related to #23