-
-
Notifications
You must be signed in to change notification settings - Fork 130
Do Not Reference, Fully Qualify Type Names #70
Conversation
… with schema consumers.
Wouldn't it be also/more useful to fix vue-json-schema-form to support refs? That said, seems like a fairly minimal change. Please fix the merge conflicts and squash your commits. |
It works by passing chunks of the schema to child components as props, so it would have to "flesh out" the schema ahead of time. I suppose if I were pulling json schemas from sources I didn't control I would have thought of that first :) (In either case, the functionality for this package is useful in itself.) Merge conflicts? I don't see any, but maybe I'm missing something. Also, you can choose to squash commits when accepting a PR, but sure. |
GitHub tells me there are conflicts. You probably not to rebase onto master. |
Yes I'm fairly aware I can do a squash merge, but I prefer not to if possible. |
This PR adds two options to the Reflector. I'll quote from the source:
My particular use case was taking the output and piping it into https://github.com/crickford/vue-json-schema-form and these are the changes I had to make for the output to play nicely.