Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #208 and on gitter: This PR implements a method for populating flags from an user-defined external source, such as a config file. Some properties:
Things I'm not sure about and would appreciate some discussion around:
Resolve
method. I'm not sure how an error would best be handled if propagated back up the stack? But I guess someone will implement a remote call resolver, which could lead to all sorts of interesting errors, so maybe it would be better to have it after all...(Also, naming, of course)