Add Schema.remove method to remove keys from dict (opposite of extend). #325
Conversation
voluptuous/tests/tests.py
Outdated
| @@ -399,6 +399,30 @@ def test_schema_extend_key_swap(): | |||
| assert_true((list(extended.schema)[0], Required)) | |||
|
|
|||
|
|
|||
| def test_remove(): | |||
There was a problem hiding this comment.
@benjaminweb There is also a function called test_remove on line 91 so one of these tests isn't running.
|
I'm not sure this will make it through. I had a request like this one rejected awhile ago: #261 |
|
It may be useful to have an example of when this would be used. I can imagine that the keys to remove are only known at runtime but I haven't come across that need myself. |
|
renamed test_remove to test_remove_method @svisser what would you add to the basic example in the test? Any specific you have on your mind? ;) |
|
@mprager Do you have any idea for a convincing example? Would this justify the pull request? |
|
Each piece of functionality we include adds complexity. For solutions to common problems, that's justified, but this is not such a case IMO (it is extremely niche) and it can be solved by refactoring your schemas (similarly to how one would factor out a common base class of a class inheritance hierarchy) or with an external helper function. Thanks for the contribution though. |
|
@alecthomas thanks for your consistency in pursuing simplicity! Appreciated. |
If there is
extendmethod, why not go the other way around?