Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytest.ini and tox.ini to sdist #487

Merged
merged 1 commit into from Nov 14, 2023
Merged

Conversation

mtelka
Copy link
Contributor

@mtelka mtelka commented Nov 13, 2023

No description provided.

@KapJI
Copy link
Contributor

KapJI commented Nov 14, 2023

Can you tell why is this useful? Why don't just checkout full repo if you want to run these checks?

@mtelka
Copy link
Contributor Author

mtelka commented Nov 14, 2023

I'm packaging voluptuous for OpenIndiana. During the packaging we run tests. By default we use sdists as a source for packaging and tests are run automatically. tox.ini is useful to get test dependencies too. If there is something missing somewhere we need to do some extra manual work. Of course, we can use github tarballs instead of sdist (actually we currently do exactly that), but there are two problems with github tarballs:

  1. some manual work is needed (you can see it in our python-integrate-project.conf file),
  2. github tarballs are not reliable and could change without notice, so reproducible builds are not possible.

Thank you.

@KapJI
Copy link
Contributor

KapJI commented Nov 14, 2023

Sounds reasonable, thank you.

@alecthomas alecthomas merged commit 82e87df into alecthomas:master Nov 14, 2023
6 checks passed
@alecthomas
Copy link
Owner

Agreed, makes sense, thanks!

@mtelka mtelka deleted the sdist branch November 14, 2023 21:13
@spacegaier
Copy link
Collaborator

Does it make sense to rebuild and repush the release to pypi or do we only do that for the next release (as it would introduce inconsistencies for users that already downloaded 0.14.0 as they do not have the INI files).

@mtelka
Copy link
Contributor Author

mtelka commented Nov 15, 2023

I do not need new release with these ini files added only. Thanks.

@alecthomas
Copy link
Owner

Next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants