Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored Bookmarks #243

Open
andro23 opened this issue Oct 18, 2019 · 10 comments
Open

Colored Bookmarks #243

andro23 opened this issue Oct 18, 2019 · 10 comments
Assignees
Labels
enhancement reengineering Needs high engineering efforts

Comments

@andro23
Copy link

andro23 commented Oct 18, 2019

It would be great to have the ability to create colored bookmarks and be able to use a different key combination to create each (ex. ctrl + D + 1, ctrl + D + 2, etc.) Thanks!!

@alefragnani
Copy link
Owner

Hi @andro23 ,

Do you mean different colors for each bookmark, or define grouping with colors?

@andro23
Copy link
Author

andro23 commented Oct 22, 2019

Hi Alessandro, first off, I want to thank you so much for the great work! The plugin is super awesome!
What I mean is colors to group different bookmark types. In my case for example, I would love to be able to color things to do in blue for example, things to revise in orange, things to fix in red, etc.. Thanks!

@alefragnani
Copy link
Owner

alefragnani commented Oct 22, 2019

Thank you @andro23 for your kind words. I'm glad the extension is being useful!

Bookmark groups has been requested in #159 but at the time the request was more a wizard/step by step manager, and the issue ended up out of scope. More recently, I added Labels to bookmarks, which allows you to give meaningful names for each bookmark.

I believe that adding colored tags to bookmarks would be a good improvement for navigation/categorization, but I still need to think about its UX. How you could add and see them in the Side Bar and Command Palete. I'm not sure about the jumping (custom keyboard) because extension's can't create commands in runtime (it must be pre-registered).

What do you think?

@andro23
Copy link
Author

andro23 commented Oct 23, 2019

Hi Alessandro, thanks for the quick reply!
I currently use labels as an alternative to what I need. They are very useful to clearly identify each bookmark. In the case of grouping, colored bookmarks would be very easy to spot and therefore save the time to scan all the bookmarks (or the code lines on the right side) to try to find the items TO BE REVISITED for example.

Regarding the keys, is it possible to pre-reserve a certain key combination + 0...9 (ex. ctrl + alt + k + 0, ..., ctrl + alt + k + 9)? If so, users may be given the ability to define the color of each of the 10 groups or stay with the default colors that you choose ;)

@alefragnani
Copy link
Owner

It would be possible to create N commands, and associate each one to some specific bookmark group, but this would create the limitation of having just N groups. Unfortunately, it’s not a sustainable solution.

I’ll take a look if there are new ways to do this ;-)

Hope this helps

@andro23
Copy link
Author

andro23 commented Oct 25, 2019

Hi Alessandro, that is the drawback I was thinking of unfortunately. I will leave that to your creativity then ;)
Thanks in advance !

@oatymart
Copy link

oatymart commented Dec 1, 2019

I noticed that https://github.com/alefragnani/vscode-numbered-bookmarks has the feature to change icon fill. Will this be ported to vscode-bookmarks any time soon? The reason I ask is because the default blue is quite similar to VS Code's default UI blue.

@alefragnani
Copy link
Owner

Hi @oatymart ,

It's something that I want for the upcoming releases, but I can't say when.

In fact I would like to port that, but also apply the recent Color contribution API that is available. Doing so, Color Themes (and users) could define the different color attributes using the same color syntax from VS Code itself 😄 .

In the meantime, you can change the icon itself using "bookmarks.gutterIconPath".

Hope this helps

@alefragnani
Copy link
Owner

I’m starting to play with the grouping support idea, and just remembered about this issue. At this point, I’m not sure it will be possible, but I’ll try to combine both.

Something like:

"tags": [
  {
     "name": "Personal",
     "color": "rgb(0, 255, 0)"
  },
  {
     "name": "Work",
     "color": "rgb(255, 0, 0)"
  }
 ]

Let’s see how it goes 😁

@eamodio
Copy link

eamodio commented Jan 9, 2022

This would be awesome. It would also be great to be able to "cycle" through the defined tags when toggling a bookmark (optional of course - or a separate command). And then also be able to group the side bar by the tags.

I was thinking it might be nice to have say 3 default tags/colors -- high priority (red), medium/normal priority (blue), low priority (grey?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement reengineering Needs high engineering efforts
Projects
None yet
Development

No branches or pull requests

4 participants