Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing bookmarks between duplicate workspaces #292

Closed
vassyz opened this issue Apr 23, 2020 · 3 comments
Closed

Syncing bookmarks between duplicate workspaces #292

vassyz opened this issue Apr 23, 2020 · 3 comments
Labels
caused by vscode The issue was caused by a VS Code update question

Comments

@vassyz
Copy link

vassyz commented Apr 23, 2020

When using two identical workspaces with "Duplicate Workspace in New Window",
when I add a bookmark in one workspace the bookmarks don't update in the other workspace, although I can see the JSON file updating. I unsuccessfully tried clicking the "Refresh" icon (don't really know what that does). I also tried with "Save Bookmarks In Project" on and off. The only way I can get it to work is to restart the VS Code window.

Is this a bug or am I doing something wrong?

@alefragnani
Copy link
Owner

Hi @vassyz ,

It appears you aren’t doing anything wrong, neither is a bug.

I didn’t even know about this new command, but searching references about it, it appears it doesn’t really duplicates the current workspace but instead open a new window with the same set of folders. Which in the end men’s, its a new workspace. At least it is how I understand from this command in microsoft/vscode#65169.

Another reason to think this is how it works, is because when you run the command, the new window has an “untitled workspace name”, instead of the the same name from the original workspace. So, you end up with “another workspace”.

If that’s the case, the bookmarks won’t be synced. When the bookmarks are saved, they are relative to the Folder/Workspace, so each one will have its own set of bookmarks. The saveBookmarksInProject setting on other hand, won’t work for you either, because it is not supported on Workspaces (more details in this comment). The issue #193 tracks the update to support that.

Hope this helps

@alefragnani alefragnani added caused by vscode The issue was caused by a VS Code update question labels Apr 24, 2020
@vassyz
Copy link
Author

vassyz commented Apr 24, 2020

@alefragnani thank you for your detailed answer. I will try to change my workflow to adapt to the technical limitations. My biggest issue now is that it's confusing what bookmarks are in which workspace. I will uncheck saveBookmarksInProject and use bookmarks just in one workspace.

@alefragnani
Copy link
Owner

No problem! I always try to help users as much as possible.

I suggest you to turn off saveBookmarksInProject for this case, and stay tuned for the proper release of multiple window support (microsoft/vscode#43188). When it happens, I’ll still need to update the extension to support sync (watch and update bookmarks from the other window ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
caused by vscode The issue was caused by a VS Code update question
Projects
None yet
Development

No branches or pull requests

2 participants