Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed an example of .jenkins #31

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

kimitaka
Copy link
Contributor

@kimitaka kimitaka commented Feb 6, 2019

The URL to a Jenkins project must end with "/". If it doesn't, we can't open a console page correctly because Jenkins Status combine specified URL, a build number and "/console" like this.

opn(settings.url + status.buildNr.toString() + "/console");

I think this is not a bug, but an incorrect example of ".jenkins" file make new users confused. So I opened this pull request.

@alefragnani
Copy link
Owner

Hi @kimitaka ,

Good catch! It's really a bug/typo in README

Thank you

@alefragnani alefragnani self-assigned this Feb 6, 2019
@alefragnani alefragnani added the bug label Feb 6, 2019
@alefragnani alefragnani merged commit 6f427de into alefragnani:master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants