Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip authentication when username is none #35

Merged
merged 1 commit into from
Feb 22, 2020
Merged

Skip authentication when username is none #35

merged 1 commit into from
Feb 22, 2020

Conversation

leeopop
Copy link
Contributor

@leeopop leeopop commented Apr 19, 2019

Web server blocks anonymous access when dummy userinfo is given.
Enable authentication only when username is not empty.

Fixes #34

@leeopop
Copy link
Contributor Author

leeopop commented Apr 19, 2019

... and I have hard times building my fork as vscode-whats-new is private.
Would you mind letting this repo as public to enable public builds?

@alefragnani alefragnani self-assigned this May 8, 2019
@alefragnani
Copy link
Owner

Yes, the vscode-whats-new repository is private, so you can't build the extension from source right now.

I'm refactoring some of my extensions, and this would be handled in this process. You can ignore it until the proper refactoring is released for the extensions.

@alefragnani alefragnani added this to the 4.0.0 milestone Feb 18, 2020
@alefragnani alefragnani merged commit 5de2a7f into alefragnani:master Feb 22, 2020
alefragnani added a commit that referenced this pull request Feb 22, 2020
@leeopop leeopop deleted the feature-conditional-auth branch February 27, 2020 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP authentication should be enabled only when id/pw is given
2 participants