Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Paren comments (* do not properly auto-close #141

Closed
CharlesAverill opened this issue Dec 12, 2023 · 2 comments · Fixed by #142
Closed

[BUG] - Paren comments (* do not properly auto-close #141

CharlesAverill opened this issue Dec 12, 2023 · 2 comments · Fixed by #142
Assignees
Labels
Milestone

Comments

@CharlesAverill
Copy link

Environment/version

  • Extension version: v9.6.0
  • VSCode version:
$ code --version
1.83.0
e7e037083ff4455cf320e344325dacb480062c3c
x64
  • OS version:
$ neofetch --stdout
--------------------- 
OS: Pop!_OS 22.04 LTS x86_64 
Kernel: 6.2.0-76060200-generic 

Steps to reproduce

Paren comments (* are autoclosed with ) instead of *), likely because the textmate language is greedily matching ( first. Not sure if there's a fix for this, I haven't dealt with the xml form of tmlanguages before.

@alefragnani
Copy link
Owner

Hi @CharlesAverill ,

First of all, sorry for the late reply.

About the issue, in fact, I guess it is not related to .tmlanguage at all, as the auto closing pairs are defined in a separate file (pascal.configuration.json). Simply adding a new entry ["(*", "*)"], seems to work just fine.

It should be available in the next release.

Thanks for reporting

@alefragnani alefragnani added this to the December 2023 milestone Dec 28, 2023
@alefragnani alefragnani self-assigned this Dec 28, 2023
@CharlesAverill
Copy link
Author

CharlesAverill commented Dec 28, 2023 via email

alefragnani added a commit that referenced this issue Dec 28, 2023
…losing-pairs

fix comment auto closing pairs (Closes #141)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants