Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grammar based on Monaco Language PR #43

Closed
8 tasks done
alefragnani opened this issue Jan 19, 2019 · 0 comments
Closed
8 tasks done

Update grammar based on Monaco Language PR #43

alefragnani opened this issue Jan 19, 2019 · 0 comments
Assignees
Milestone

Comments

@alefragnani
Copy link
Owner

alefragnani commented Jan 19, 2019

While developing the PR to add Pascal support in Monaco Editor, I have noted some errors in the current grammar. Also, a few updates could be made to add new features recently added in VS Code.

News Features / Updates

  • Add code folding for $REGION
  • Add < > as AutoClosingPair and SurroundingPairs
  • Add "hex" as a new identifier for numbers
  • Add #number as a valid string pattern

Fixes

  • Remove " (doublequotes) as AutoClosingPair and SurroundingPairs
  • 0x is not a valid number pattern
  • -- is not a valid line comment pattern (like previoulsy fixed in Atom)
  • "..." (doublequotes) is not a valid string pattern
@alefragnani alefragnani added this to the 7.2.0 milestone Jan 19, 2019
@alefragnani alefragnani self-assigned this Jan 19, 2019
@alefragnani alefragnani changed the title Update grammar Update grammar based on Monaco Language PR Feb 13, 2019
@alefragnani alefragnani changed the title Update grammar based on Monaco Language PR Update grammar based Feb 13, 2019
alefragnani added a commit that referenced this issue Feb 13, 2019
@alefragnani alefragnani changed the title Update grammar based Update grammar Feb 13, 2019
@alefragnani alefragnani changed the title Update grammar Update grammar based on Monaco Language PR Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant