Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Improve "Disabled Projects" experience #368

Open
krutoo opened this issue May 6, 2020 · 7 comments
Open

[FEATURE] - Improve "Disabled Projects" experience #368

krutoo opened this issue May 6, 2020 · 7 comments

Comments

@krutoo
Copy link

krutoo commented May 6, 2020

Hi, first of all, thanks for great extension!

I have project in list named as "something.js". When i rename it to just "something" (remove ".js")
i get error "Project already exists!".

What am I doing wrong?

  • Mac OS Catalina
  • VS Code 1.44.2
  • Project Manager 10.12.0
@alefragnani
Copy link
Owner

Hi @krutoo ,

This message appears in two occasions:

  • Using the Rename Project command in the Side Bar’s context menu
  • Using the Save Project command in Command Palette

it checks for same name - case insensitive projects, so simply removing .js from the project name is a totally different name.

How did you renamed the project?

@krutoo
Copy link
Author

krutoo commented May 7, 2020

@alefragnani I use context menu (right mouse button click) of list item in side bar - Rename project

@alefragnani
Copy link
Owner

@krutoo Maybe you have disabled project (using the Disable Project context menu.

You could check all your projects, using the Edit Projects command. It will open the projects.json file (where the projects are stored), then you can search for another project called something.

Hope this helps

@krutoo
Copy link
Author

krutoo commented May 7, 2020

@alefragnani Yes, i have disable project with target name, thank you

@krutoo krutoo closed this as completed May 7, 2020
@alefragnani
Copy link
Owner

@krutoo That’s great to see it works!

Thinking about it, I decided to reopen the issue, but now as an enhancement. I see at least two points possibilities:

  • It should say there is a disabled project with the same name, and maybe provide alternatives (rename the disabled, provide another name, etc)
  • It should have a Show disabled projects button on the top of the panel, so you could see them, when needed.

Hope this helps

@alefragnani alefragnani reopened this May 7, 2020
@alefragnani alefragnani self-assigned this May 7, 2020
@alefragnani alefragnani changed the title "Project already exists!" after remove some characters from project name Show disabled projects In Side Bar and better handling while renaming projects (while conflict with disabled ones) May 7, 2020
@alefragnani
Copy link
Owner

Use eye-closed and eye from https://microsoft.github.io/vscode-codicons/dist/codicon.html

@alefragnani alefragnani changed the title Show disabled projects In Side Bar and better handling while renaming projects (while conflict with disabled ones) [FEATURE] - Improve "Disabled Projects" experience Nov 20, 2020
@alefragnani
Copy link
Owner

  • Add a Show/Hide Disabled Projects Button in the Favorites view
  • Disabled projects should be visually distinct, while visible
  • Even disabled/hidden, projects should be considered alive so conflict should be correctly handled (original issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants