Fix spelling discrepancies

[k-kuroguro]

I found mixing 'writable' and 'writeable' in your code, fix 'writable' to 'writeable', because 'writeable' was there from the initial commit, and 'writable' seemed to have been added later.

[alefragnani]

Hi @k-kuroguro ,

This kind of typo (on settings) are the worst, because fixing it will make those settings stop to work 😞 .

I'm not sure how widely used are, so I don't know it worth a migration routine, but I'll see.

Thank you

[k-kuroguro]

Hi @alefragnani, thanks for reviewing.

You're right, we must be cautious about updates.
So, I think you might want to leave the current configuration as deprecated like the following.

{
   "fileAccess.hideWhenWritable": {
      "type": "boolean",
      "default": false,
      "description": "Hide the Status Bar indicator when the file is Writable",
      "markdownDeprecationMessage": "**Deprecated**: Please use `#fileAccess.hideWhenWriteable#` instead.",
      "deprecationMessage": "Deprecated: Please use fileAccess.hideWhenWriteable instead."
   },
   "fileAccess.hideWhenWriteable": {
      "type": "boolean",
      "default": false,
      "description": "Hide the Status Bar indicator when the file is Writeable"
   }
}

[alefragnani]

Hi @k-kuroguro ,

I think deprecating is a good alternative. 👍

But, you could simplify the message, removing the Deprecated: prefix. Simply use "Use fileAccess.hideWhenWriteable instead.".

Thank you

[k-kuroguro]

Hi @alefragnani , thanks for replying.

I have a little problem about deprecated settings.

1. contributes.colors doesnt have deprecationMessage field.
2. I want to check whether the new or old settings are being used for compatibility. As bellow

const config = typeof workspace.getConfiguration("fileAccess").get('hideWhenWriteable') === 'undefined'
   ? workspace.getConfiguration("fileAccess").get("hideWhenWritable", false)
   : workspace.getConfiguration("fileAccess").get("hideWhenWriteable", false);

but `get()` function does not returns undefined because it has default value as false in `package.json`.

I'll change as following

1. Write "Deprecated: Use fileAccess.writeableForeground instead." on description field instead of deprecationMessage.
2. Remove default value in package.json.

Both will remove the existing code. Is there a better way to do this?

[alefragnani]

Hi @k-kuroguro ,

Well, I didn’t notice contributes.colors doesn’t have deprecation. In this case, no need for special treatment.

Simply update the setting. No need to check for old values or anything like that. The old value will be ignored, the user will open settings.json to check and it will see it underlined. In the end, the user will fix the typo 😬 .

[k-kuroguro]

@alefragnani, thanks for answering!

I add deprecated msg only contributes.configuration as you said.