Create get all events util and rename getEvents to getEvent #33

valentinbeggi · 2022-02-04T14:57:31Z

fixes #15

smbkr

I have left some review comments - let me know your thoughts.

I also wonder if the addition of yargs should be split into a separate PR since it's not really required for the main feature here? Edit: looks like it's already in #29 too

src/helpers/eventBridge.ts

valentinbeggi force-pushed the create-get-all-events-util branch 2 times, most recently from d05a205 to e0f57bc Compare February 4, 2022 15:24

valentinbeggi changed the title ~~Create get all events util~~ Create get all events util and rename getEvents to getEvent Feb 4, 2022

valentinbeggi force-pushed the create-get-all-events-util branch from e0f57bc to 2a77913 Compare February 4, 2022 15:25

smbkr reviewed Feb 9, 2022

View reviewed changes

valentinbeggi added 3 commits April 1, 2022 11:49

feat: add getAllEvents method to EventBridge class

c3feb37

♻️ Rename getEvent to getLastEvent

fcab1b5

♻️ Make getAllEvents while loop code more explicit

0d5ed2a

valentinbeggi force-pushed the create-get-all-events-util branch from 2a77913 to 0d5ed2a Compare April 1, 2022 09:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create get all events util and rename getEvents to getEvent #33

Create get all events util and rename getEvents to getEvent #33

valentinbeggi commented Feb 4, 2022

smbkr left a comment •

edited

Create get all events util and rename getEvents to getEvent #33

Are you sure you want to change the base?

Create get all events util and rename getEvents to getEvent #33

Conversation

valentinbeggi commented Feb 4, 2022

smbkr left a comment • edited

Choose a reason for hiding this comment

smbkr left a comment •

edited