Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor erroring system #117

Merged
merged 19 commits into from
Apr 4, 2020
Merged

Refactor erroring system #117

merged 19 commits into from
Apr 4, 2020

Conversation

alejandrohdezma
Copy link
Owner

What has been done in this PR?

  • Use Try instead of Either[Throwable, A]
  • Move failure case classes out of Json companion object and extend them from Throwable.
  • Use throwable's cause system to propagate failure causes.

@alejandrohdezma
Convert Fail intro abstract class with message field
4867219 
Move `readableMessage` values into this new field
@alejandrohdezma
Extract Fail from Json
9be17d4
@alejandrohdezma
Convert Fail intro Throwable
fab1fd8
@alejandrohdezma
Remove Fail and use Throwable as top class
ed31fb8
@alejandrohdezma
Move decoder failures under Decoder.Failure
0b98e4c
@alejandrohdezma
Move client failures under client
eb063e6
@alejandrohdezma
Move json failures under Json.Failures
ad256c0
@alejandrohdezma
Rename Path to InvalidPath
757b893
@alejandrohdezma
No need to use Unknown
5ea1a99
@alejandrohdezma
Use logger.trace for http.client errors
ca8b1fc
@alejandrohdezma
Use Try[A] instead of Either[Throwable, A] for Result
4c38196
@alejandrohdezma
Remove Result type alias
4a220b2
@alejandrohdezma
Rename failure package to error
2e270ae
@alejandrohdezma
Return Try instead of Either in Repository methods
e3fe41a 
Create new `GithubError` to hold failures in this service
@alejandrohdezma
Move Json and Decoder failures into json.error packages
ee252f1
@alejandrohdezma
Use the throwable cause system to keep failure information
56477e8
@alejandrohdezma
Use Try.get instead of sys.error
65b2feb
@alejandrohdezma
Avoid name collisions between models and URL models
7ff023e
@alejandrohdezma
Improve error messages
25d1111
@alejandrohdezma alejandrohdezma merged commit 3ec96d4 into master Apr 4, 2020
@alejandrohdezma alejandrohdezma deleted the refactor-errors branch April 4, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@alejandrohdezma