Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add githubEnabled setting to be used instead of downloadInfoFromGithub #178

Merged
merged 5 commits into from
Apr 20, 2020

Conversation

alejandrohdezma
Copy link
Owner

@alejandrohdezma alejandrohdezma commented Apr 20, 2020

What has been done in this PR?

Add a new setting githubEnabled that will be used instead of downloadInfoFromGithub.

Instead of relying on environment variables, this new setting will be used via the following command aliases:

  • github: Sets githubEnabled to true
  • githubOn: Sets githubEnable to true
  • githubOff: Sets githubEnabled to false

❗ Important note. The downloadInfoFromGithub has been deprecated and will be removed on version 0.9.0 along with using DOWNLOAD_INFO_FROM_GITHUB environment variable mechanism. If anyone wants to keep that functionality, add the following to build.sbt:

ThisBuild / githubEnabled := sys.env.contains("DOWNLOAD_INFO_FROM_GITHUB")

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #178 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #178   +/-   ##
=======================================
  Coverage   82.60%   82.60%           
=======================================
  Files          21       21           
  Lines         184      184           
  Branches        1        0    -1     
=======================================
  Hits          152      152           
  Misses         32       32           
Impacted Files Coverage Δ
...m/alejandrohdezma/sbt/github/SbtGithubPlugin.scala 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bf6032...cf45f4f. Read the comment docs.

@alejandrohdezma alejandrohdezma merged commit 5ba2724 into master Apr 20, 2020
@alejandrohdezma alejandrohdezma deleted the feature/enable-github branch April 20, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant